Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Loader bug #6

Open
xialeiliu opened this issue Dec 15, 2020 · 7 comments
Open

Loader bug #6

xialeiliu opened this issue Dec 15, 2020 · 7 comments

Comments

@xialeiliu
Copy link

Could you confirm that in the following line, self.shot_num should be self.way_num?It is not consistent with mini-imagenet-tools and gives error.
https://github.com/yaoyao-liu/tiered-imagenet-tools/blob/master/tiered_imagenet_dataloader.py#L189

@yaoyao-liu
Copy link
Owner

Thanks for reporting this issue. I have updated the code.

@xialeiliu
Copy link
Author

Thanks for your quick reply.

Another question about using import scipy.misc as scm,
in mini-imagenet-tools, import imageio is used, I am wondering what's the reason to change it?
For me it seems imageio works fine and scm gives me problems.

@yaoyao-liu
Copy link
Owner

In the initial versions for the two projects, I use similar libraries.
After that, I updated the mini-imagenet-tools more often, but I didn't update this project correspondingly. Sorry about that.

You may directly use the dataloader for miniImageNet on tieredImageNet with minor changes. You may also apply the dataloader I used in this project for different datasets.

@xialeiliu
Copy link
Author

Thanks, good to know your new project.

And last thing is that the following line works for me using:
class_idxs = list(range(0, self.way_num))

https://github.com/yaoyao-liu/tiered-imagenet-tools/blob/master/tiered_imagenet_dataloader.py#L147

with these fixes, it works fine for me now.

@yaoyao-liu
Copy link
Owner

Thanks.
You may create a pull request for this issue so that I can include you in the contributors' list.

@xialeiliu
Copy link
Author

xialeiliu commented Dec 15, 2020

It's fine, only several minor points, you could fix it directly if that is correct to you.
Thanks.

@yaoyao-liu
Copy link
Owner

Thanks for the contributions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants