Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Doesn't declare all its dependencies #6

Open
autarch opened this issue Sep 4, 2016 · 4 comments
Open

Doesn't declare all its dependencies #6

autarch opened this issue Sep 4, 2016 · 4 comments

Comments

@autarch
Copy link

autarch commented Sep 4, 2016

This explains the travis failures I'm seeing in BreadBoard, like https://travis-ci.org/stevan/BreadBoard/jobs/157500790

You're missing Dist::Zilla::Plugin::Test::ReportPrereqs and maybe more.

I'd patch this but I can't figure out out how your bundle works. The bundle repo itself doesn't have a dist.ini file, but you've checked in a bunch of files generated by dzil! I am so confused.

@yanick
Copy link
Owner

yanick commented Sep 4, 2016

You are looking at the releases branch, which is the branch that matches what is being released to CPAN. What you want to checkout is master, which is the working branch, with the dist.ini and all that jazz.

@autarch
Copy link
Author

autarch commented Sep 5, 2016

Ah, I see. It's a bit weird to have that be the default branch I see on GitHub. I'd suggest doing master like most other repos. I didn't even think to check if I wasn't looking at master. Anyway, the missing prereqs are still a thing. You might want to consider using AutoPrereqs. I find it way easier than maintaining a huge list by hand.

@yanick
Copy link
Owner

yanick commented Sep 5, 2016

On 2016-09-04 08:08 PM, Dave Rolsky wrote:

Ah, I see. It's a bit weird to have that be the default branch I see on
GitHub. I'd suggest doing master like most other repos.

I actually thought about it (I know, shocking), and I think having the
'release' branch as the facing one being the most sensed. There are a
few reasons for that.

  • For every person confused by the lack of dist.ini in releases, there
    are 10 peeps going "this is not like the code on CPAN at all, what is
    going on?" or, most typically, "Dzilla? OMG, no, no, for the love of God
    noooooo".
  • One of the things that my dzil config does is to create the README.mkd
    for the main github project page.
  • Allows to do installs via cpanm git://github.com/yanick/whatev.git

You might want to consider using
|AutoPrereqs|. I find it /way/ easier than maintaining a huge list by hand.

I usually do. In this case I went for the manual because somebody asked
me a while ago not to hard require dependencies such that they can do

[@Filter]
-bundle=YANICK
-remove=Sumfin

but I should be able to jerryrig something there. Gimme a few hours.

@autarch
Copy link
Author

autarch commented Sep 5, 2016

For every person confused by the lack of dist.ini in releases, there are 10 peeps going "this is not like the code on CPAN at all, what is going on?" or, most typically, "Dzilla? OMG, no, no, for the love of God
noooooo".

Well, this is a dzil bundle, so I think most folks would expect to find a dist.ini in the tree.

That said, I agree that this can be a problem, which is why I just have dzil check all these files right back into master after a release. It's a little less clean, but it's much simpler, and should satisfy all the constituencies.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants