Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Resource Detector interface #57

Open
wperron opened this issue Dec 21, 2022 · 2 comments
Open

Add Resource Detector interface #57

wperron opened this issue Dec 21, 2022 · 2 comments

Comments

@wperron
Copy link

wperron commented Dec 21, 2022

The API should provide a way to provider custom resource detectors.

@plantfansam
Copy link
Contributor

Seems reasonable to me!

@yangxikun
Copy link
Owner

There is a simple way. We can return a resource in custom resource detectors, then pass it to

tracer_provider.new(processor, {
    sampler = always_on_sampler,
    resource = detected_resource,
})

Is this OK?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants