Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean&Easy-to-maintain code: yambopy full integration into the aiida-yambo plugin #255

Open
mikibonacci opened this issue Aug 21, 2023 · 0 comments
Assignees

Comments

@mikibonacci
Copy link
Member

(1) Reduce the plugin code.
To make a more clean and maintainable code, the idea is to export all the Yambo-related functions and methods into yambopy, e.g.

  • convergence analysis
  • parsing of results from yambo (partially borrowed from yambopy)
  • inputs generation (already massively borrowed from yambopy)

In this way the plugin will be simple to maintain, and we can focus on adding more complex work chain with additional features, e.g. yambopy-band interpolations (electronic and excitonic bands) ...

(2) Direct use of yambopy.
With this in mind, we have also to consider to add automatic error handling for yambopy errors (like indeed interpolation errors).
A clean way to do would be to create (restart) workchains to run yambopy commands, meaning that the plugin will be able to use yambopy also as remote executable, not only as local post processing set of modules. The plugin will then be an AiiDA plugin for both yambo and yambopy.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants