Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Thoughts for next steps #93

Open
jema28 opened this issue Nov 2, 2020 · 7 comments
Open

Thoughts for next steps #93

jema28 opened this issue Nov 2, 2020 · 7 comments

Comments

@jema28
Copy link
Contributor

jema28 commented Nov 2, 2020

Hi @thejoefriel @yosefanajjar,

Having a think about next steps and adding the rest of the pages. Here are a few initial thoughts:

On the current design - release-v1:

  • I quite like the pages without the accents, it's more simple and minimal. Would be good to have your thoughts on this.
    Our Approach and Services could be spiced up on the landing page though.
  • I think keeping the desktop layout as close to the mobile and tablet is good, especially for the first few versions of the site.
  • Need to look into the case study layout / include the metadata / deliverables section. Currently missing.
  • As @thejoefriel mentioned:
    • Need to look into replacing the stock photos. The case studies could be changed to the main header images but I'm not sure how good this would look. Will have to think about this.
    • Add Tempo case study
  • Currently there's no link to an external site for PressPad. @thejoefriel this doesn't exist yet right?
  • Haven't added the Connect 5 case study yet, do you think we should add Tempo first @thejoefriel?

Approach suggestion for the next pages:

  • Start with the mobile layout first and work up. This worked well.
  • I think the case study in react works well. Markdown caused a lot of problems for me. Hope this is okay @yosefanajjar?
  • Keep things as simple as possible (this is more of a note to me :P)

Priorities:

  • I think working on Tempo, Connect 5 case studies and our team page would be good next priorities. What do you think @thejoefriel?

Would be good to get your thoughts on the above @thejoefriel @yosefanajjar in this thread 😸

@jema28
Copy link
Contributor Author

jema28 commented Nov 2, 2020

Mentioned this on discord/slack but would also be good to sort the deployment so the site's on the Yalla account. @thejoefriel could you send over the details for this?

@yosefanajjar
Copy link
Contributor

@jema28 thanks for sharing this here are my thoughts:

  • I like having the accents on desktop and tablet so I have no problem removing them on mobile, the current design looks fine to me and I will do my best to bring it to live

I wouldn't like to make a lot of changes to the current Figma design as we were waiting for it to be finished for a good time and I'm just concerned that we keep making changes to it cause that will delay the final release of the project

  • There won't be a lot of first versions of the site I was helping with getting something done by Sunday and my plan was to continue working + merging the changes we need into master so that we can ship it by the end of this month max

  • I agree we need to pass metadata to the case studies and handle styling better, I am willing to discuss using normal React pages instead of MDX but the reasons I went with MDX in the first place are:

    • Fewer components to import
    • Ideal for content writing in Gatsby sites (seen a lot of blogs done this exact way)
    • Generating pages is done better with MDX

I noticed your comments on having problems with MDX what issues did you have?

  • As for the next steps I agree with your priorities but will add to them one more which is merging release-v1 into master

and I would like to keep the release-v1 branch as the production/deployed branch and stop creating newer versions and go for a full release of the website does that work well with you both? @jema28 and @thejoefriel

@yosefanajjar
Copy link
Contributor

Was taking a look at the content of the case studies and I realized they don't look as similar as I thought they would and I'm now considering to ditch MDX because as I said MDX is better for building blogs or something like that where you have a lot of text content but in our case, the case studies have a lot of common components inside them.

@jema28
Copy link
Contributor Author

jema28 commented Nov 3, 2020

Thanks @yosefanajjar!

I like the landing page as it is now on desktop and tablet. The only parts I'd change back are approach section and work section once we have the extra case studies. In general, if we go back to the original design for desktop, we need to be a bit careful about responsiveness, spacing and alignment - I can go check this as we go. I really like some of the sections without accents e.g. this part of the landing page -
Screenshot 2020-11-03 at 05 21 00

  • I think the approach page could go back to the original but need to watch the responsiveness again.

  • Yeh the versions of the site was more aimed at me as there will be new case studies and tweaks that I will work on in the future.

  • I like the case studies sharing the same header look but need to look into going back to the original design for the first sections of the case study pages.

  • The case study content may be different in the future but I think mdx was confusing to me, especially the lack of indents and mixing styled components in.

  • Yeh the next release will be everything in figma. Anything else released in the future I'll sort.

@jema28
Copy link
Contributor Author

jema28 commented Nov 3, 2020

@fadeomar Heard from Yosef that you're working on the team pages, thank you! Wanted to make sure you read the message above that we're not having accents on mobile and the introduction on each page should be free from accents also (on all sizes). Let me know if that's all clear?

@yosefanajjar
Copy link
Contributor

@jema28 would be better if you go ahead and remove the accents we don't need from the Figma it will help me and @fadeomar understand better, let me know if that's possible!

@jema28
Copy link
Contributor Author

jema28 commented Nov 3, 2020

Sure, I'll go through and do this @yosefanajjar, will put it under 'Mockups-v2'

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants