From 0cee723871ce56ee2b583dd75888604c1e13d48d Mon Sep 17 00:00:00 2001
From: Alex Luker <alex.luker@gmail.com>
Date: Mon, 29 Jul 2024 09:38:33 +0100
Subject: [PATCH] Remove the ability to edit a sales session as we dont support
 it on the producer. Change throw error to attach the error as a cause so we
 can add the meaningful description. Couldnt find out the ecmascript version
 shopify is using to know whether this is fully supported

---
 web/frontend/pages/SalesSession.jsx           | 50 -------------------
 .../controllers/edit-current-sales-session.js | 45 -----------------
 .../sales-session/controllers/index.js        |  2 -
 .../use-cases/edit-current-sales-session.js   | 30 -----------
 web/oidc-router.js                            |  2 +-
 web/utils/index.js                            |  7 +--
 6 files changed, 2 insertions(+), 134 deletions(-)
 delete mode 100644 web/modules/sales-session/controllers/edit-current-sales-session.js
 delete mode 100644 web/modules/sales-session/use-cases/edit-current-sales-session.js

diff --git a/web/frontend/pages/SalesSession.jsx b/web/frontend/pages/SalesSession.jsx
index 2d19555..b3a5a53 100644
--- a/web/frontend/pages/SalesSession.jsx
+++ b/web/frontend/pages/SalesSession.jsx
@@ -90,22 +90,6 @@ export default function SalesSession() {
     },
   });
 
-  const {
-    mutateAsync: editCurrentSalesSession,
-    isLoading: editCurrentSalesSessionIsLoading,
-    error: editCurrentSalesSessionError,
-  } = useAppMutation({
-    reactQueryOptions: {
-      onSuccess: async () => {
-        await queryClient.invalidateQueries("/api/sales-session");
-        setShowSuccessAlert({
-          show: true,
-          type: "updated",
-        });
-      },
-    },
-  });
-
   const {
     mutateAsync: completeCurrentSalesSession,
     isLoading: completeCurrentSalesSessionIsLoading,
@@ -134,22 +118,6 @@ export default function SalesSession() {
     },
   });
 
-  const handleOnEditCurrentSalesSessionClick = async () => {
-    await editCurrentSalesSession({
-      url: "/api/sales-session/current",
-      fetchInit: {
-        method: "PATCH",
-        headers: {
-          "Content-Type": "application/json",
-        },
-        body: JSON.stringify({
-          startDate: startDate.toISOString(),
-          sessionDurationInDays: Number(sessionDurationInDays),
-        }),
-      },
-    });
-  };
-
   const handleOnFinishCurrentSalesSessionClick = async () => {
     await completeCurrentSalesSession({
       url: "/api/sales-session/current/complete",
@@ -314,20 +282,6 @@ export default function SalesSession() {
           {createSalesSessionIsLoading ? "Loading..." : "Create Sales Session"}
         </Button>
 
-        <Button
-          variant="contained"
-          type="button"
-          onClick={handleOnEditCurrentSalesSessionClick}
-          disabled={
-            editCurrentSalesSessionIsLoading ||
-            !currentSalesSessionData?.currentSalesSession?.isActive
-          }
-        >
-          {editCurrentSalesSessionIsLoading
-            ? "Loading..."
-            : "Edit Current Sales Session"}
-        </Button>
-
         <Button
           variant="contained"
           type="button"
@@ -346,10 +300,6 @@ export default function SalesSession() {
           <Alert severity="error">{createSalesSessionError.message}</Alert>
         )}
 
-        {editCurrentSalesSessionError && (
-          <Alert severity="error">{editCurrentSalesSessionError.message}</Alert>
-        )}
-
         {completeCurrentSalesSessionError && (
           <Alert severity="error">
             {completeCurrentSalesSessionError.message}
diff --git a/web/modules/sales-session/controllers/edit-current-sales-session.js b/web/modules/sales-session/controllers/edit-current-sales-session.js
deleted file mode 100644
index 3c60dc0..0000000
--- a/web/modules/sales-session/controllers/edit-current-sales-session.js
+++ /dev/null
@@ -1,45 +0,0 @@
-import moment from 'moment';
-import editCurrentSalesSessionUseCase from '../use-cases/edit-current-sales-session.js';
-
-const editCurrentSalesSession = async (req, res, next) => {
-  try {
-    const {
-      body: { startDate, sessionDurationInDays }
-    } = req;
-
-    // validate the startDate should be in the future
-
-    if (!startDate) {
-      return res.status(400).json({
-        message: 'Start Date is required'
-      });
-    }
-
-    if (!sessionDurationInDays) {
-      return res.status(400).json({
-        message: 'Session Duration is required'
-      });
-    }
-
-    // Commented out per GH-78
-    // check the startDate is in the future
-    // if (moment(startDate).isBefore(moment().startOf('day'))) {
-    //   return res.status(400).json({
-    //     message: 'Start Date should be in the future'
-    //   });
-    // }
-
-    await editCurrentSalesSessionUseCase({
-      startDate,
-      sessionDurationInDays
-    });
-    return res.status(200).json({
-      message: 'Sales session updated successfully'
-    });
-  } catch (err) {
-    console.log('err', err);
-    return next(err);
-  }
-};
-
-export default editCurrentSalesSession;
diff --git a/web/modules/sales-session/controllers/index.js b/web/modules/sales-session/controllers/index.js
index 18ad357..e3ceee7 100644
--- a/web/modules/sales-session/controllers/index.js
+++ b/web/modules/sales-session/controllers/index.js
@@ -2,7 +2,6 @@ import { Router } from 'express';
 
 import createSalesSession from './create-sales-session.js';
 import getCurrentSalesSession from './get-current-sales-session.js';
-import editCurrentSalesSession from './edit-current-sales-session.js';
 import deleteCurrentSalesSession from './delete-current-sales-session.js';
 import completeCurrentSalesSession from './complete-current-sales-session.js';
 
@@ -11,7 +10,6 @@ const salesSessionRouter = Router();
 salesSessionRouter.post('/', createSalesSession);
 salesSessionRouter.get('/', getCurrentSalesSession);
 salesSessionRouter.delete('/current', deleteCurrentSalesSession);
-salesSessionRouter.patch('/current', editCurrentSalesSession);
 salesSessionRouter.patch('/current/complete', completeCurrentSalesSession);
 
 export default salesSessionRouter;
diff --git a/web/modules/sales-session/use-cases/edit-current-sales-session.js b/web/modules/sales-session/use-cases/edit-current-sales-session.js
deleted file mode 100644
index 13a52bc..0000000
--- a/web/modules/sales-session/use-cases/edit-current-sales-session.js
+++ /dev/null
@@ -1,30 +0,0 @@
-import moment from 'moment';
-import { query } from '../../../database/connect.js';
-
-const editCurrentSalesSessionUseCase = async ({
-  startDate,
-  sessionDurationInDays
-}) => {
-  const startDateValue = moment(startDate).toISOString();
-  const endDate = moment(startDate)
-    .add(sessionDurationInDays, 'days')
-    .toISOString();
-
-  const sql = `
-  UPDATE sales_sessions
-    SET
-      start_date = $1, 
-      session_duration = $2,
-      end_date = $3
-    WHERE
-      is_active = true`;
-
-  try {
-    await query(sql, [startDateValue, sessionDurationInDays, endDate]);
-  } catch (err) {
-    console.error(err);
-    throw new Error('Failed to edit sales session', err);
-  }
-};
-
-export default editCurrentSalesSessionUseCase;
diff --git a/web/oidc-router.js b/web/oidc-router.js
index b2f16af..82dfd17 100644
--- a/web/oidc-router.js
+++ b/web/oidc-router.js
@@ -18,7 +18,7 @@ oidcRouter.get('/success', async (req, res) => {
   res
     .status(200)
     .set('Content-Type', 'text/html')
-    .send(readFileSync(join(STATIC_PATH, 'success.html')))
+    .send(readFileSync(join(STATIC_PATH, 'success.html')));
 });
 
 oidcRouter.get(
diff --git a/web/utils/index.js b/web/utils/index.js
index dc24cfe..0745fdd 100644
--- a/web/utils/index.js
+++ b/web/utils/index.js
@@ -1,4 +1,3 @@
-import * as qs from 'qs';
 
 export const convertShopifyGraphQLIdToNumber = (id) => {
   if (!id) return null;
@@ -7,11 +6,7 @@ export const convertShopifyGraphQLIdToNumber = (id) => {
 };
 
 export function throwError(message, errorObj) {
-  if (errorObj) {
-    throw errorObj;
-  } else {
-    throw new Error(message);
-  }
+  throw new Error(message, errorObj ? {cause: errorObj} : null);
 }
 
 export function getTargetStringFromSemanticId(url, key) {