-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
IYY-283: Site editors can create a ½ - ½ layout | IYY-284: Site editors can create a ⅓ - ⅓ - ⅓ layout #442
base: iyy-sprint-03
Are you sure you want to change the base?
Conversation
✅ Deploy Preview for dev-component-library-twig ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work and looks great to me. I added others to chime in before we bring it in.
… colors are set for each theme
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks amazing! do you have the list of approved blocks for each section? I know in the past we had a table to keep track of them
@miketullo95 Yes, the approved list of components is as follows: Fifty-Fifty
Thirty-Thirty-Thirty
|
Potential easy wins (not related to IYY project, just brainstorming here) 50/50
70/30
|
@miketullo95 Could you capture that request in a ticket? It would require a decent amount of work and definitely wouldn't be quick 😆 . |
@joetower oh, this wasn't specifically a request for this PR/work package, just thinking out-loud and wanted a record of potential stuff that can be taken on in the future 😆. Will definitely make a ticket for it now |
@miketullo95 Okay, sounds great! Thank you. |
@joetower feedback from the university printer:
|
@miketullo95 Apologies for sending you to another PR, but could you please test your changes here: #445 I made newer changes to the layout files in that branch and wanted to keep subsequent updates in the same place. The divider was a bit thinner in the Also, I added |
@joetower amazing as always! and apologies, forgot that those requests were CL based 😆 |
IYY-301: Add Link Grid component as an option in the new 1/2-1/2 layout
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've been working on this PR for the back-end, wiring, and UI parts to this ticket and all of this looks great to me. Approved!
IYY-283: Site editors can create a ½ - ½ layout | IYY-284: Site editors can create a ⅓ - ⅓ - ⅓ layout
Description of work
fifty-fifty
thirty-thirty-thirty
two-thirds-one-thirds
Testing Link(s)
Functional Review Steps
fifty-fifty
thirty-thirty-thirty
two-thirds-one-thirds
one
,two
,three
,four
,true
orfalse
fifty-fifty
the second column has an accordion to illustrate that it can only be added on a fifty-fifth layoutIYY-layouts.webm
Accessibility Review