From f3ef4815e45eaab1fc71a1c18c20e673a2e49c31 Mon Sep 17 00:00:00 2001 From: David Blankenship Date: Thu, 7 Nov 2024 14:40:35 -0500 Subject: [PATCH 1/7] fix(v1.10.0): remove margin from layout containers We were getting margins when editing content, which hadn't happened before. --- css/layout-builder.css | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/css/layout-builder.css b/css/layout-builder.css index 16a24743b..752311462 100644 --- a/css/layout-builder.css +++ b/css/layout-builder.css @@ -295,3 +295,7 @@ div[data-drupal-selector="edit-block-form"] { margin-top: auto; } +/* Layout containers now have a margin due to stable9 */ +.layout-container { + margin: 0; +} From ee8bf893acd61c1864c902f0777b09f0a60cb4de Mon Sep 17 00:00:00 2001 From: David Blankenship Date: Thu, 7 Nov 2024 16:19:43 -0500 Subject: [PATCH 2/7] fix(layout-builder-browser): hide empty block search items Layout builder browser now displays empty items when searching. This ensures that those items are no longer seen, and only those that match are kept. --- css/layout-builder.css | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/css/layout-builder.css b/css/layout-builder.css index 752311462..53e35d570 100644 --- a/css/layout-builder.css +++ b/css/layout-builder.css @@ -299,3 +299,8 @@ div[data-drupal-selector="edit-block-form"] { .layout-container { margin: 0; } + +/* On layout builder browser search, hide entries that are actually empty */ +.layout-builder-browser-block-item:has(a[style*="display: none"]) { + display: none; +} From bd976f9cf295f1951c2a0ad75d32ec4bc2dec238 Mon Sep 17 00:00:00 2001 From: David Blankenship Date: Thu, 7 Nov 2024 16:30:04 -0500 Subject: [PATCH 3/7] fix(accordions): fix text-within gin colors This commit updates the styles for the layout builder browser block item in dark mode. It adds a new selector for the hover and focus states of table rows, which fixes an issue with the text-within property on tables in dark mode. --- css/layout-builder.css | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/css/layout-builder.css b/css/layout-builder.css index 53e35d570..c7c0dcf46 100644 --- a/css/layout-builder.css +++ b/css/layout-builder.css @@ -304,3 +304,9 @@ div[data-drupal-selector="edit-block-form"] { .layout-builder-browser-block-item:has(a[style*="display: none"]) { display: none; } + +/* For some reason text-within on tables in dark mode go wrong */ +.gin--dark-mode tr:hover, tr:focus-within { + color: var(--gin-color-text); + background: var(--gin-bg-secondary); +} From d7b010c1eab412b4fbd73b91482f8cf1f5e67425 Mon Sep 17 00:00:00 2001 From: David Blankenship Date: Mon, 11 Nov 2024 10:02:52 -0500 Subject: [PATCH 4/7] fix(v1.10.0): fix hover/focus contrast on linkit --- css/admin-theme.css | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/css/admin-theme.css b/css/admin-theme.css index 2a4c8da60..333e6a788 100644 --- a/css/admin-theme.css +++ b/css/admin-theme.css @@ -128,6 +128,14 @@ html.gin--dark-mode form.layout-builder-configure-block.glb-form { color: var(--gin-bg-layer3); } +/* Dark mode was not passing contrast */ +.gin--dark-mode + .linkit-ui-autocomplete.ui-menu + .linkit-result-line-wrapper.ui-state-active { + color: var(--gin-color-primary); + background-color: var(--gin-bg-layer3); +} + /* // Offcanvas toolbar styles */ From f7798e481a78b7f6d8e97dce249fee0f14c1ac01 Mon Sep 17 00:00:00 2001 From: David Blankenship Date: Mon, 11 Nov 2024 10:51:42 -0500 Subject: [PATCH 5/7] fix(v1.10.0): fix typo --- css/layout-builder.css | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/css/layout-builder.css b/css/layout-builder.css index c7c0dcf46..dd809c868 100644 --- a/css/layout-builder.css +++ b/css/layout-builder.css @@ -306,7 +306,8 @@ div[data-drupal-selector="edit-block-form"] { } /* For some reason text-within on tables in dark mode go wrong */ -.gin--dark-mode tr:hover, tr:focus-within { +.gin--dark-mode tr:hover, +.gin--dark-mode tr:focus-within { color: var(--gin-color-text); background: var(--gin-bg-secondary); } From a4ed1f5dfe51cb5758003e0a051170b9b4209018 Mon Sep 17 00:00:00 2001 From: David Blankenship Date: Mon, 11 Nov 2024 10:52:05 -0500 Subject: [PATCH 6/7] fix(v1.10.0): fix vertical ellipsis under content bleeding When selecting the ellipsis on the accordion, for instance, when having multiple accordion items, you'd see the button that is on the rows underneath display on top of the paragraphs action section. This fixes this to be above it and not show through. --- css/layout-builder.css | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/css/layout-builder.css b/css/layout-builder.css index dd809c868..554d26771 100644 --- a/css/layout-builder.css +++ b/css/layout-builder.css @@ -311,3 +311,11 @@ div[data-drupal-selector="edit-block-form"] { color: var(--gin-color-text); background: var(--gin-bg-secondary); } + +/** + * The header for some reason was allowing the z-index of the table cells to + * show above it. + */ +th.field-label { + z-index: 105; +} From 5ee7cf3c784a88356a3113d2547926cabfcf519b Mon Sep 17 00:00:00 2001 From: David Blankenship Date: Mon, 11 Nov 2024 10:53:21 -0500 Subject: [PATCH 7/7] fix(v1.10.0): remove strange gradient on collapsed paragraphs In some cases, the paragraphs in a block being collapsed resulted in a gradient showing next to the edit button. We are unsure what purpose this fulfilled, so we hid it. --- css/layout-builder.css | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/css/layout-builder.css b/css/layout-builder.css index 554d26771..89b275e86 100644 --- a/css/layout-builder.css +++ b/css/layout-builder.css @@ -319,3 +319,8 @@ div[data-drupal-selector="edit-block-form"] { th.field-label { z-index: 105; } + +/* A gradient was displaying on certain states. This removes it. */ +.has-multiple-fields-remove-button .js .paragraphs-collapsed-description:after { + display: none; +}