Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature request: json tag field #12493

Closed
2 tasks done
hackedpassword opened this issue Nov 18, 2024 · 3 comments
Closed
2 tasks done

Feature request: json tag field #12493

hackedpassword opened this issue Nov 18, 2024 · 3 comments
Labels

Comments

@hackedpassword
Copy link

Before creating

  • This is NOT a gameplay feature from Civ VI, BNW, or outside - see Roadmap
  • This is NOT a gameplay feature from Vanilla Civ V or from G&K - If so, it should be a comment in Missing features from Civ V - G&K #4697

Problem Description

Tags can be arbitrarily set as an ambiguous unique. Would it be more apparent if a tags field were introduced? Same behavior, specific field.

Related Issue Links

No response

Desired Solution

{
	"name": "SomeUnit",
	"tags": [
		"Robot",
		"Metal",
	],
},

Alternative Approaches

As noted.

Additional Context

Standard current tag use intermixes tags into uniques, when tags aren't really uniques, whereas tags alone do nothing, while a uniques functional use being present is in creating modifiers.

@SeventhM
Copy link
Collaborator

My personal opinion, Idk if it matches others:

From a code perspective, I don't think this makes too much sense. Especially with the recent ability to use conditionals for tags, all tags functionally do function as uniques, even if they have no code behind. There's also at least one official unique (fresh water) that code wise is checked as if it were a tag, making the distinction that much more murky to me

Also, one advantage of the unique system is we can reduce the number of fields we need to work from with more flexibility on how everything works. Adding a new field for just tags seems odd with that as a goal

@yairm210
Copy link
Owner

There is no advantage and several disadvantages.

  • We'll need to handle both types or force all existing mods to change
  • A lot of work was put into performance for checking uniques that will need to be replicated
  • Mechanisms such as 'hidden from users' for tags, which work because they're uniques, will fail
    All in all, a definitive 'no' from me

@yairm210 yairm210 closed this as not planned Won't fix, can't repro, duplicate, stale Nov 19, 2024
@hackedpassword
Copy link
Author

Appreciate the consideration and the detailed insights!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants