Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature request: Unit Type Icons as missing Unit Icons. #12307

Open
2 tasks done
prod0ad opened this issue Oct 17, 2024 · 6 comments
Open
2 tasks done

Feature request: Unit Type Icons as missing Unit Icons. #12307

prod0ad opened this issue Oct 17, 2024 · 6 comments
Labels

Comments

@prod0ad
Copy link

prod0ad commented Oct 17, 2024

Before creating

  • This is NOT a gameplay feature from Civ VI, BNW, or outside - see Roadmap
  • This is NOT a gameplay feature from Vanilla Civ V or from G&K - If so, it should be a comment in Missing features from Civ V - G&K #4697

Problem Description

I noticed we can have UnitTypeIcons and thought those could be used as missing specific unit icons of that type. As a placeholder, a design choice, or to save icon space.

Examples:
A mod that uses Icons for Classes/types, not specific units.
A mod where some units, say heroes, could share the same Icon.

Related Issue Links

No response

Desired Solution

The game reads files as described.

Alternative Approaches

While we're at this, is there a way to hide unused domain categories from civilopedia?

Additional Context

No response

@yairm210
Copy link
Owner

Interesting! Good idea!

@prod0ad
Copy link
Author

prod0ad commented Oct 20, 2024

Nice:) Maybe this could be extended to other things too?

Like default icons for resource, tech, policy (maybe the main branch could be a fallback for sub-policies), unit-type sprite icons etc. Especially the later I see as most useful.

@prod0ad
Copy link
Author

prod0ad commented Oct 20, 2024

Btw just tested, doesn't seem to work.

New units ignore the unit-type icon, the rest fallback to base game ones. Or to other active perm audiovisual mod they share unit names with, is that intended?

@yairm210
Copy link
Owner

Welp, I done goofed, my bad

@prod0ad
Copy link
Author

prod0ad commented Oct 25, 2024

It works now on the map. But not in city construction queue, civilopedia and combat screen. Not sure if I've missed any.

Btw I noticed Unciv ram use increase with time (reached up to almost 9 GB and major computer lag). Is this normal, or, since I've never noticed that before even in longer sessions, some new memory leak or something?

@yairm210
Copy link
Owner

That's definitely a problem, but whether it's new or not isn't something I can know 🤔

@yairm210 yairm210 reopened this Oct 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants
@yairm210 @prod0ad and others