From 319a7c139681eeee25ace086b611ebf226d85753 Mon Sep 17 00:00:00 2001 From: Johannes Doberer Date: Thu, 24 Mar 2022 13:45:45 +0100 Subject: [PATCH] Remove experimental flag for webcomponents (#2622) --- core/src/services/routing.js | 4 ++-- docs/web-component.md | 8 ++------ .../luigi-client-link-manager-features.spec.js | 10 ---------- .../src/luigi-config/extended/settings.js | 1 - website/fiddle/src/defaultConfig.js | 3 --- 5 files changed, 4 insertions(+), 22 deletions(-) diff --git a/core/src/services/routing.js b/core/src/services/routing.js index 5400949327..26d7b022a7 100644 --- a/core/src/services/routing.js +++ b/core/src/services/routing.js @@ -351,13 +351,13 @@ class RoutingClass { } } - if (nodeObject.compound && GenericHelpers.requestExperimentalFeature('webcomponents', true)) { + if (nodeObject.compound) { if (iContainer) { iContainer.classList.add('lui-webComponent'); } Iframe.switchActiveIframe(iframeElement, undefined, false); this.navigateWebComponentCompound(component, nodeObject); - } else if (nodeObject.webcomponent && GenericHelpers.requestExperimentalFeature('webcomponents', true)) { + } else if (nodeObject.webcomponent) { if (iContainer) { iContainer.classList.add('lui-webComponent'); } diff --git a/docs/web-component.md b/docs/web-component.md index 175a29b732..34c03b2300 100644 --- a/docs/web-component.md +++ b/docs/web-component.md @@ -51,15 +51,11 @@ Luigi.setConfig({ ... ] } - settings: { - ... - experimental: { - webcomponents:true - } - ....... }) ``` +> **NOTE:** With Luigi version NEXTRELEASE we removed the experimental flag for webcomponents. + ### Write a Web Component There are a couple of differences between Luigi Web Components and standard ones: diff --git a/test/e2e-test-application/e2e/tests/1-angular/luigi-client-link-manager-features.spec.js b/test/e2e-test-application/e2e/tests/1-angular/luigi-client-link-manager-features.spec.js index ad56cd752e..877b7009ff 100644 --- a/test/e2e-test-application/e2e/tests/1-angular/luigi-client-link-manager-features.spec.js +++ b/test/e2e-test-application/e2e/tests/1-angular/luigi-client-link-manager-features.spec.js @@ -632,11 +632,6 @@ describe('Luigi client linkManager', () => { describe('Webcomponent visibleForFeatureToggles test', () => { beforeEach(() => { cy.visitLoggedIn('/projects/pr1/wc_grid'); - cy.window().then(win => { - const config = win.Luigi.getConfig(); - config.settings.experimental = { webcomponents: true }; - win.Luigi.configChanged(); - }); }); it('open webcomponent with visibleForFeatureToggles', () => { @@ -654,11 +649,6 @@ describe('Luigi client linkManager', () => { describe('Webcomponent compound view test', () => { beforeEach(() => { cy.visitLoggedIn('/projects/pr1/wc_grid_compound'); - cy.window().then(win => { - const config = win.Luigi.getConfig(); - config.settings.experimental = { webcomponents: true }; - win.Luigi.configChanged(); - }); }); it('open webcomponent btn', () => { diff --git a/test/e2e-test-application/src/luigi-config/extended/settings.js b/test/e2e-test-application/src/luigi-config/extended/settings.js index c610039a04..3b061ab4ab 100644 --- a/test/e2e-test-application/src/luigi-config/extended/settings.js +++ b/test/e2e-test-application/src/luigi-config/extended/settings.js @@ -65,7 +65,6 @@ class Settings { // experimental = { // profileMenuFiori3: true, // globalNav: true, - // webcomponents: true // }; // globalSideNavigation = true; } diff --git a/website/fiddle/src/defaultConfig.js b/website/fiddle/src/defaultConfig.js index f739b1240e..25d9ce3b4c 100644 --- a/website/fiddle/src/defaultConfig.js +++ b/website/fiddle/src/defaultConfig.js @@ -188,9 +188,6 @@ Luigi.setConfig({ logo: 'img/luigi.png', title: 'Luigi Fiddle' }, - experimental: { - webcomponents:true - }, burgerTooltip: { navExpanded: 'Collapse navigation', navCollapsed: 'Expand navigation'