Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No wheels for python 3.11 #82

Open
davidbrochart opened this issue Oct 25, 2022 · 3 comments
Open

No wheels for python 3.11 #82

davidbrochart opened this issue Oct 25, 2022 · 3 comments

Comments

@davidbrochart
Copy link
Collaborator

Python 3.11 is out and already available on conda-forge, could we release y-py with wheels for it?

@encukou
Copy link

encukou commented Nov 9, 2022

Would it be worth it to build for Python's stable ABI, so the built wheels are compatible across Python versions?
I'm not familiar with Rust (though I can help with Python stable ABI), but it should be possible with:

[dependencies.pyo3]
features = ["extension-module", "abi3-py37"]

(The resulting wheel should still be tested on all supported Python versions.)

@Waidhoferj
Copy link
Collaborator

Hey @encukou, I was checking out your abi3 proposal repository. How significant is the performance overhead that you mention?

@encukou
Copy link

encukou commented Dec 21, 2022

You aren't likely to notice unless you're counting CPU instructions or optimizing for CPU cache at the Rust/Python boundary.
The biggest slowdown I know is that rather than accessing memory directly, “everything” is a function call. In particular, Py_INCREF is a C function call rather than C int increment.

My abi3 repo is a collection of notes, some of which are outdated now. The proposal was PEP 652 and official docs are at https://docs.python.org/3/c-api/stable.html. Let me know if I can clarify something.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants