Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Does clickhouse-sqlalchemy 3.0.0 support sqlalchemy of the version 1.4.*? #294

Open
MordorianGuy opened this issue Feb 29, 2024 · 5 comments

Comments

@MordorianGuy
Copy link

MordorianGuy commented Feb 29, 2024

Does clickhouse-sqlalchemy 3.0.0 support sqlalchemy of the version 1.4.*? If no, will there be further development of clickhouse-sqlalchemy 2.* version for supporting sqlalchemy 1.*, for instance, like a separate branch?

@MordorianGuy MordorianGuy changed the title Does clickhouse-sqlalchemy support sqlalchemy of the version 1.4.*? Does clickhouse-sqlalchemy support sqlalchemy of the version **1.4.\***? Feb 29, 2024
@MordorianGuy MordorianGuy changed the title Does clickhouse-sqlalchemy support sqlalchemy of the version **1.4.\***? Does clickhouse-sqlalchemy support sqlalchemy of the version 1.4.\*? Feb 29, 2024
@MordorianGuy MordorianGuy changed the title Does clickhouse-sqlalchemy support sqlalchemy of the version 1.4.\*? Does clickhouse-sqlalchemy support sqlalchemy of the version 1.4.*? Feb 29, 2024
@MordorianGuy MordorianGuy changed the title Does clickhouse-sqlalchemy support sqlalchemy of the version 1.4.*? Does clickhouse-sqlalchemy 3.0.0 support sqlalchemy of the version 1.4.*? Mar 4, 2024
@xzkostyan
Copy link
Owner

Please use clickhouse-sqlalchemy==0.2.x for SA==1.4.x.

What do you mean in further development? Critical bug fixes may be backported.

@MordorianGuy
Copy link
Author

I mean supporting all new features. SA 1.4 is the only variant if you use airflow, for example.

@xzkostyan
Copy link
Owner

@MordorianGuy what new features do you need? May be I can easily backport them to 0.2.x branch.

@MordorianGuy
Copy link
Author

Like DISTINCT ON, Date32. For a while, I created a fork of 0.2.6 branch where realised these features and added some more like subexpression aliases & INTERVAL. It would be great to know your plans about older versions so that we can make the decision to develop our own fork or to support your branch with pull requests.

@xzkostyan
Copy link
Owner

You can backport existing features from master and make PR to version-0,2.x branch. I'll release package on pypi. New features should be submitted to master as well. I guess community need them too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants