Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Running kalk.exe standalone from explorer has broken prompts in output #13

Open
baldurk opened this issue Dec 2, 2020 · 4 comments
Open
Labels
bug Something isn't working

Comments

@baldurk
Copy link

baldurk commented Dec 2, 2020

If I run kalk.exe straight from explorer it pops up a command window but the color codes seem to be broken and display as strings:

image

When I run this from e.g. conemu it works fine. Not sure if this is something about detecting console capabilities to turn off the color output or what might be the difference?

image

I'm not sure what information you might need from me - this is 0.1.1 downloaded straight from https://kalk.dev . I can build from source and debug or provide anything else you might need since I imagine this is system-specific and not a general problem.

btw I'm not sure if this is a separate unrelated issue but my gut feeling tells me it's too coincidental and it's probably related to the same thing. Even in conemu if I type in an unrecognised command it seems to break the prompt from then on:

image

And then if I type I typed this just once I get:

image

If that needs to be split into a separate issue please let me know, I didn't want to file two bugs since it felt like probably the same root cause.

@xoofx
Copy link
Owner

xoofx commented Dec 2, 2020

Which OS are you? kalk indeed requires a compatible terminal that supports ANSI escape code sequences, which comes now almost by default with Windows 10. There is something in the code that tries to detect if it is supported and disable it, but seems that it doesn't work.

Otherwise, yeah, I have tried kalk only from a new Windows Terminal prompt and on MacOS. Even for the Linux version, I tried it from WSL2 from a Windows Terminal. I haven't tried in other terminals... not sure it is fixable easily on my side depending on the terminal tricks they are doing to support some ANSI escape code sequences...

@xoofx xoofx added the bug Something isn't working label Dec 2, 2020
@baldurk
Copy link
Author

baldurk commented Dec 2, 2020

Ah yeh, I'm on windows 7. Indeed on my windows 10 test machine it works fine, I should have thought to try that. If this isn't feasible to support then it's fine to close this. I'll see if I can hack something locally maybe as it mostly works aside from the error message case in conemu.

@xoofx
Copy link
Owner

xoofx commented Dec 2, 2020

So I just tried kalk on Windows 10 from conemu and it's working as well (likely conemu is not trying to do anything with escape codes)

Weird thing is that you are getting a double \n in your conemu...
Anyway, I can't really help because I don't have a Windows 7 anymore around me (and I'm not sure I want to spend time on this myself! 😅 )

@siliconvoodoo
Copy link

ansi colors are supported in windows 10 since the creators update (but not before).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants