Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Attempting to import from src/node_modules directory doesn't work #60

Open
danimbrogno opened this issue Aug 12, 2016 · 0 comments
Open

Comments

@danimbrogno
Copy link

danimbrogno commented Aug 12, 2016

I'm finding that I cannot import packages that have been installed in src/node_modules, I get 'module not found' errors. Installing these packages into the top level node_modules directory fixes the issue, but I think we should be able to have our non testing related packages only installed in the src/node_modules folder.

I'm not sure why webpack isn't finding this node_modules directory, as node should scan the tree for all available install locations right?

My workaround was to change the webpackConfig and explicitly list the node_modules directory in src as a root.

var webpackConfig = {
resolve: {
root: [
path.join(wallaby.projectCacheDir, 'src'),
path.join(wallaby.localProjectDir, 'src','node_modules')
],
extensions: ['', '.js', '.jsx', '.json']
},
module: {
loaders: [
// JavaScript is handled by the Wallaby Babel compiler
{ test: /.json$/, loader: 'json-loader' }
]
}
};

Any ideas on if this is the correct approach here? If so should we make this change?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant