From 029e2ecaabc006c5c1640f5a34838ddab492449c Mon Sep 17 00:00:00 2001 From: Marin Nozhchev Date: Fri, 12 Apr 2024 18:50:30 +0300 Subject: [PATCH] fixup: remove TODOs (pr feedback) --- drivers/clickhouse/clickhouse.go | 3 --- 1 file changed, 3 deletions(-) diff --git a/drivers/clickhouse/clickhouse.go b/drivers/clickhouse/clickhouse.go index 24c244b0d8..59ccc6f1dd 100644 --- a/drivers/clickhouse/clickhouse.go +++ b/drivers/clickhouse/clickhouse.go @@ -65,7 +65,6 @@ func CopyWithInsert(ctx context.Context, db *sql.DB, rows *sql.Rows, table strin } table += "(" + strings.Join(columns, ", ") + ")" } - // TODO if the db supports multiple rows per insert, create batches of 10 rows query = "INSERT INTO " + table + " VALUES (" + strings.Repeat("?, ", clen-1) + "?)" } tx, err := db.BeginTx(ctx, nil) @@ -109,8 +108,6 @@ func CopyWithInsert(ctx context.Context, db *sql.DB, rows *sql.Rows, table strin } n += rn } - // TODO if using batches, flush the last batch, - // TODO prepare another statement and count remaining rows err = tx.Commit() if err != nil { return n, fmt.Errorf("failed to commit transaction: %w", err)