Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pca.d file generated by xpca contains nonsense #182

Open
xhuw opened this issue Aug 6, 2024 · 0 comments
Open

pca.d file generated by xpca contains nonsense #182

xhuw opened this issue Aug 6, 2024 · 0 comments

Comments

@xhuw
Copy link
Contributor

xhuw commented Aug 6, 2024

Run the test test_cmake[pca_libs] and comment out the lines that delete the build dir. look in the file .build/pca.d which is supposed to be a valid depfile mapping targets to dependencies. It contains nonsense. On my machine it looks like this:

/home/huw/projects/xcommon_cmake/tests/pca_libs/app_pca_libs/.build//home/huw/projects/xcommon_cmake/tests/pca_libs/_l_mod0/_l_mod0/src/mod0.xc.o:
/home/huw/projects/xcommon_cmake/tests/pca_libs/app_pca_libs/.build//home/huw/projects/xcommon_cmake/tests/pca_libs/_l_mod1/_l_mod1/src/mod1.xc.o:
/home/huw/projects/xcommon_cmake/tests/pca_libs/app_pca_libs/.build//home/huw/projects/xcommon_cmake/tests/pca_libs/app_pca_libs/src/pca_libs.xc.o:

Those paths are invalid and it's also specifying no dependencies.

what are the consequences of this? This is unproven, but I expect that partial builds will not be completed properly when PCA is enabled, leading to invalid binaries.

Another consequence is that we can't use ninja because the cmake depfile converter for ninja in cmake 3.21 sees it as an invalid depfile.
xhuw added a commit to xhuw/xcommon_cmake that referenced this issue Aug 6, 2024
@xhuw
Updates to pca
6046d79 
Use "VERBATIM" rather than "EXPAND_LISTS" which lets use use more
sensible command strings and is recommended by the docs.

comment out depfile as its buggy, see xmos#182
xhuw added a commit to xhuw/xcommon_cmake that referenced this issue Aug 6, 2024
@xhuw
Updates to pca
bd41601 
Use "VERBATIM" rather than "EXPAND_LISTS" which lets use use more
sensible command strings and is recommended by the docs.

comment out depfile as its buggy, see xmos#182
@xhuw xhuw changed the title pca.d file generated by xpca is contains nonsense pca.d file generated by xpca contains nonsense Aug 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@xhuw