Skip to content
This repository has been archived by the owner on Mar 14, 2023. It is now read-only.

Raising BadRequestError will itself cause error ... #5

Open
GoogleCodeExporter opened this issue Aug 13, 2015 · 3 comments
Open

Raising BadRequestError will itself cause error ... #5

GoogleCodeExporter opened this issue Aug 13, 2015 · 3 comments

Comments

@GoogleCodeExporter
Copy link

When responding to an error code 400 (line 88-89 in
./gdata-1.1.0/lib/gdata/client.rb) the code will throw an error. This is
because code is passing response.body when it should be passing response

Proposed fix:

Original:

raise BadRequestError, response.body

Proposed:

raise BadRequestError.new(response)

Cheers,

Vince


Original issue reported on code.google.com by [email protected] on 13 Jul 2009 at 10:44

@GoogleCodeExporter
Copy link
Author

I'm seeing the same problem. This is really annoying b/c it hides the actual 
request
error.

Original comment by [email protected] on 11 Sep 2009 at 6:50

@GoogleCodeExporter
Copy link
Author

This seemed to fix the problem for me


sudo vi /Library/Ruby/Gems/1.8/gems/gdata-1.1.0/lib/gdata/client/base.rb

change

when 400
  raise BadRequestError, response.body

to

when 400
  raise BadRequestError.new(response)

Original comment by [email protected] on 11 Sep 2009 at 6:55

@GoogleCodeExporter
Copy link
Author

Fixed in 1.1.1 but the status here was never updated.

Original comment by [email protected] on 9 May 2010 at 11:50

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

1 participant