Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

About the loss function #13

Open
DylanWusee opened this issue Jun 27, 2019 · 4 comments
Open

About the loss function #13

DylanWusee opened this issue Jun 27, 2019 · 4 comments

Comments

@DylanWusee
Copy link

Hi Xingyu,

Thank you for releasing code here.

I noticed that the loss function used in the code is different from the one in the Paper. In the paper, you used a huber loss together with a cycle-consistency regularization.

Are there particular reasons that you removed it from your code?

Thank you very much.
Best,
Dylan

@xingyul
Copy link
Owner

xingyul commented Jul 1, 2019

We provided huber loss in the code.

@DylanWusee
Copy link
Author

But the huber loss in your code doesn't have the cycle-consistency regularization term. Is that correct?

@xingyul
Copy link
Owner

xingyul commented Jul 1, 2019

That's correct. Cycle-consistency regularization should be easy to implement. Do you want me to upload the implementation?

@HimangiM
Copy link

HimangiM commented Sep 1, 2019

I am having some issues in implementing it. It would be great if you can upload it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants