Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to DBConnection 1.2 #196

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

fishcakez
Copy link
Contributor

@fishcakez fishcakez commented Aug 11, 2017

DBConnection 1.2 is not released yet but this PR tracks progress.

  • Use database transaction status to prevent transaction errors
  • Support new low level cursor API with per fetch max rows
  • Handle execute errors while using cursors
  • Test that transaction status is updated for more query result packets

@coveralls
Copy link

coveralls commented Aug 11, 2017

Coverage Status

Coverage increased (+0.3%) to 66.033% when pulling 1d3b6a2 on fishcakez:jf-db_conn-1.2 into c654c88 on xerions:master.

@coveralls
Copy link

Coverage Status

Coverage increased (+3.4%) to 69.108% when pulling 789c9a6 on fishcakez:jf-db_conn-1.2 into c654c88 on xerions:master.

1 similar comment
@coveralls
Copy link

Coverage Status

Coverage increased (+3.4%) to 69.108% when pulling 789c9a6 on fishcakez:jf-db_conn-1.2 into c654c88 on xerions:master.

@fishcakez
Copy link
Contributor Author

Still a bit more work to be done here: more tests and configuring max rows at per fetch level.

@coveralls
Copy link

coveralls commented Aug 12, 2017

Coverage Status

Coverage increased (+3.8%) to 69.507% when pulling c570005 on fishcakez:jf-db_conn-1.2 into c654c88 on xerions:master.

@coveralls
Copy link

coveralls commented Aug 13, 2017

Coverage Status

Coverage increased (+4.2%) to 69.973% when pulling 696d037 on fishcakez:jf-db_conn-1.2 into c654c88 on xerions:master.

1 similar comment
@coveralls
Copy link

Coverage Status

Coverage increased (+4.2%) to 69.973% when pulling 696d037 on fishcakez:jf-db_conn-1.2 into c654c88 on xerions:master.

@coveralls
Copy link

coveralls commented Nov 26, 2017

Coverage Status

Coverage increased (+3.4%) to 71.04% when pulling cf37d53 on fishcakez:jf-db_conn-1.2 into e9eb29f on xerions:master.

6 similar comments
@coveralls
Copy link

Coverage Status

Coverage increased (+3.4%) to 71.04% when pulling cf37d53 on fishcakez:jf-db_conn-1.2 into e9eb29f on xerions:master.

@coveralls
Copy link

coveralls commented Nov 26, 2017

Coverage Status

Coverage increased (+3.4%) to 71.04% when pulling cf37d53 on fishcakez:jf-db_conn-1.2 into e9eb29f on xerions:master.

@coveralls
Copy link

Coverage Status

Coverage increased (+3.4%) to 71.04% when pulling cf37d53 on fishcakez:jf-db_conn-1.2 into e9eb29f on xerions:master.

@coveralls
Copy link

Coverage Status

Coverage increased (+3.4%) to 71.04% when pulling cf37d53 on fishcakez:jf-db_conn-1.2 into e9eb29f on xerions:master.

@coveralls
Copy link

Coverage Status

Coverage increased (+3.4%) to 71.04% when pulling cf37d53 on fishcakez:jf-db_conn-1.2 into e9eb29f on xerions:master.

@coveralls
Copy link

Coverage Status

Coverage increased (+3.4%) to 71.04% when pulling cf37d53 on fishcakez:jf-db_conn-1.2 into e9eb29f on xerions:master.

@josevalim josevalim mentioned this pull request Aug 31, 2018
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants