save if a error occurs during sending of the request #22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Instead of returning the exception message in a variable maybe would be better to try to propagate the exception. It can give us the opportunity to customize the exception for this case and act accordingly. |
|
@aibes1001 : So you mean to reraise the exception inside the loki_request.py and to catch the exception inside the _send method? |
|
Yes, and then in _send() method we can handle the exception as we want (e.g. print the exception message, activate an error flag, etc.) |
aibes1001
reviewed
Nov 30, 2024
aibes1001
reviewed
Nov 30, 2024
added 2 commits
December 2, 2024 11:03
aibes1001
approved these changes
Dec 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This saves the error which occurs during sending in the Handler, so we have the ability to react on it (e.g. by disabling the logger if the server is not available).