This repository has been archived by the owner on Mar 16, 2020. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 18
/
MAINTAINERS
47 lines (34 loc) · 1.73 KB
/
MAINTAINERS
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
List of maintainers and how to submit changes
=============================================
Please try to follow the guidelines below. They will make things
easier on the maintainers. Not all of these guidelines matter for every
trivial patch so apply some common sense.
If you are unsure about something written here, please raise an issue on
this GitHub project.
0. Before starting a big project, discuss it on the list first :-)
1. Always test your changes, however small, by both targetted
manual testing and by running the unit tests.
2. When adding new functionality, include test cases for any
* important; or
* difficult to manually test; or
* easy to break
new code.
3. All submissions must be made under the terms of the "Developer's
Certificate of Origin" (DCO) and should include a Signed-off-by:
line.
4. Make your patch(es) available by creating one or more github pull
requests. Each pull request should be separately reviewable and
mergable. Only patches which must be committed together should be
in the same pull request.
5. Each patch should include a descriptive commit comment that helps
understand why the patch is necessary and why it works. This will
be used both for initial review and for new people to understand
how the code works later.
6. For bonus points, ensure the project still builds in between every
patch in a set: this helps hunt down future regressions with 'bisect'.
7. Make sure you have the right to submit any changes you make. If you
do changes at work you may find your employer owns the patches
instead of you.
Maintainers list
----------------
* Rob Dobson <[email protected]>