CP-41819: Update except and print() syntax to Python3, use logging #18
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TLDR: I expect a review of this PR to take maybe 2-3 minutes or so, it's really short and easy:
The only change that is only obvious by reviewing each commit by commit is this change:
It should be clear - if not preferred, I can remove the last one or two commits.
2nd Pull request for the Python3 migration of xenserver-status-report: - Updates the except and print() syntax to support Python3 - Updates the prints to `stderr` to use `logging` or more readable code.
It is split into 5 incremental commits with each commit making one dedicated step of the updates:
I tested the uses of logging to work as expected and
pylint
(in GitHub CI) ensured that I fixed any logging argument errors (logging functions need format strings) that I had initially made.The combined change is small, and can easily reviewed at once (or commit by commit).