Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

transforms: use rewriter and listener in convert-stencil-to-csl-stencil #3538

Open
wants to merge 1 commit into
base: math-fehr/stack/1
Choose a base branch
from

Conversation

math-fehr
Copy link
Collaborator

@math-fehr math-fehr commented Nov 29, 2024

Stacked PRs:


transforms: use rewriter and listener in convert-stencil-to-csl-stencil

The pass was not propagating the listener from the PatternRewriter, and
thus some operations were modified without notifying the rewrite
worklist.

The pass was not propagating the listener from the PatternRewriter, and
thus some operations were modified without notifying the rewrite
worklist.

stack-info: PR: #3538, branch: math-fehr/stack/2
@math-fehr
Copy link
Collaborator Author

@n-io, can you confirm that the coeffs attribute in csl_stencil.apply do not have an order?
This PR changed the order in which the coefficients are stored, but my understanding is that this is irrelevant?

@math-fehr math-fehr self-assigned this Nov 29, 2024
@math-fehr math-fehr added the transformations Changes or adds a transformatio label Nov 29, 2024
Copy link

codecov bot commented Nov 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.36%. Comparing base (eb30740) to head (afc4913).

Additional details and impacted files
@@                  Coverage Diff                  @@
##           math-fehr/stack/1    #3538      +/-   ##
=====================================================
- Coverage              90.36%   90.36%   -0.01%     
=====================================================
  Files                    466      466              
  Lines                  58516    58517       +1     
  Branches                5583     5583              
=====================================================
  Hits                   52879    52879              
- Misses                  4209     4210       +1     
  Partials                1428     1428              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@n-io
Copy link
Collaborator

n-io commented Nov 29, 2024

Yes, the order is irrelevant since the stencil index is stored with the coefficient value.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
transformations Changes or adds a transformatio
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants