You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Here is a clear and concise description of what the problem is:
On OS X (Mac) in Chrome, users can use e.g. CMD + 1 to switch to the first open tab in the current window. The keyboard shortcut handling implementation in Chorus inadvertently disables this feature by allowing the Cmd key press to pass but capturing the 1 key press.
Expected Behavior
Here is a clear and concise description of what was expected to happen:
Pressing Cmd + 1 in Chorus switches from the current tab to the first open browser tab.
Actual Behavior
The key press is captured and event.preventDefault() applied, resulting in no tab switch.
Possible Fix
Don't capture/event.preventDefault() keys when they are occurring while a "meta" key is pressed.
I have fixed it locally in this line
Bug report
Describe the bug
Here is a clear and concise description of what the problem is:
On OS X (Mac) in Chrome, users can use e.g.
CMD + 1
to switch to the first open tab in the current window. The keyboard shortcut handling implementation in Chorus inadvertently disables this feature by allowing theCmd
key press to pass but capturing the1
key press.Expected Behavior
Here is a clear and concise description of what was expected to happen:
Pressing
Cmd + 1
in Chorus switches from the current tab to the first open browser tab.Actual Behavior
The key press is captured and
event.preventDefault()
applied, resulting in no tab switch.Possible Fix
Don't capture/
event.preventDefault()
keys when they are occurring while a "meta" key is pressed.I have fixed it locally in this line
chorus2/src/js/apps/input/input_app.js.coffee
Lines 81 to 82 in 8bf0317
by extending it to include
Your Environment
Used Operating system:
The text was updated successfully, but these errors were encountered: