Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integrate confidence intervals with total #262

Open
3 tasks
smishr opened this issue Feb 26, 2023 · 2 comments
Open
3 tasks

Integrate confidence intervals with total #262

smishr opened this issue Feb 26, 2023 · 2 comments
Assignees
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@smishr
Copy link
Contributor

smishr commented Feb 26, 2023

To integrate _ci function with total. See #190 for exemplar integration with mean, and keep consistency.

  • total with confidence interval options
  • Add docstrings
  • Add doctests
@smishr smishr added enhancement New feature or request good first issue Good for newcomers labels Feb 26, 2023
@nadiaenh
Copy link
Collaborator

nadiaenh commented Mar 1, 2023

I'm assuming I should build onto the work from #190 (e.g. add to ci.jl) but that PR is not merged yet. Should I push to smishr/Survey.jl when I'm done ?

@smishr
Copy link
Contributor Author

smishr commented Mar 7, 2023

I'm assuming I should build onto the work from #190 (e.g. add to ci.jl) but that PR is not merged yet. Should I push to smishr/Survey.jl when I'm done ?

I think rn we have paused working on CI until we confident on the data structure changes, if any.

But for future reference, I think you are able to clone and checkout the PR branch locally (using Github Desktop or git CLI), and continue work from there and push changes.

If above doesnt work, we can merge the PR and you can create new branch from it, and do the others in separate PRs (best option imo)

Or you may do what you suggested above. Another option would be to copy paste all the code into a newly created local branch, and continue work there. The old PR would be

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

4 participants