You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
If biometric authentication fails in authenticateUsingBiometry function, then the fake biometry factor key is not generated. The result is that fail counter is not increased on the server. This bug may affect our react-native clients, because the function is used internally to pre-authorize biometry in case of reusable authentication object is requested.
The implementation should be simple - just move the logic that determine that fake key should be generated from signatureKeysForAuthentication into biometryRelatedKeyWithAuthentication function.
On top of that, we may implement a few nice enhancements to the function. Right now, our react-native wrapper suffer with issue that if biometry is requested on iOS simulator, then there's no biometry dialog displayed. This is because on simulator, the direct access to the biometry protected keychain item always succeed, with no dialog displayed. On opposite to that, if LAContext.evaluatePolicy is used, then biometric dialog is properly displayed and the developer can decide whether it should fail or success.
So, we should reimplement authenticateUsingBiometry with using LAContext with the following benefits:
RN wrapper will properly show biometric dialogs on iOS simulators
If biometric authentication fails in
authenticateUsingBiometry
function, then the fake biometry factor key is not generated. The result is that fail counter is not increased on the server. This bug may affect our react-native clients, because the function is used internally to pre-authorize biometry in case of reusable authentication object is requested.The implementation should be simple - just move the logic that determine that fake key should be generated from
signatureKeysForAuthentication
intobiometryRelatedKeyWithAuthentication
function.On top of that, we may implement a few nice enhancements to the function. Right now, our react-native wrapper suffer with issue that if biometry is requested on iOS simulator, then there's no biometry dialog displayed. This is because on simulator, the direct access to the biometry protected keychain item always succeed, with no dialog displayed. On opposite to that, if
LAContext.evaluatePolicy
is used, then biometric dialog is properly displayed and the developer can decide whether it should fail or success.So, we should reimplement
authenticateUsingBiometry
with usingLAContext
with the following benefits:The text was updated successfully, but these errors were encountered: