Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MRSI data not being handled the same as original matlab version. #5

Open
andrewmwright opened this issue Jan 20, 2021 · 4 comments
Open

Comments

@andrewmwright
Copy link

Attached are modifications I made to the twix_map_obj.py script. My discussions of variables are commented near changes I made. Primary issues were the ixToRaw, tmp, and maar variables. There was also some broadcasting issues coming about from MRSI data, but I believe that is fixed by changing the skipLin and skipPar variables. Maybe you have more robust ideas to fix these issues. Due to the size of MRSI data I cannot upload a test set here for you to try unfortunately.

Cheers,
Andrew Wright

amw_issue_zip.zip

@sravan953
Copy link

@andrewmwright I'm not from the dev team, but as someone who cares about the compatibility of this tool with the MATLAB version, I request you to open a PR 😃

@andrewmwright
Copy link
Author

@andrewmwright I'm not from the dev team, but as someone who cares about the compatibility of this tool with the MATLAB version, I request you to open a PR 😃

@sravan953 I raised this as an issue when I submitted the zipped files. Generating a PR wasn't possible. So if you're attempting to recon raw data you should be able to use the files I zipped above. Be aware that there are other bigs I've discovered since I submitted this.

@wtclarke
Copy link
Owner

wtclarke commented Jul 8, 2021

Hi @andrewmwright , sorry for the very long delay in replying. Too many things to keep track of. Is there any chance that you could generate a PR with the bugs you have found?

@wtclarke
Copy link
Owner

wtclarke commented Jul 8, 2021

I've just taken a look at some of the changes, thanks for going through everything with so carefully. This was definitely a case of just getting something to work for the test cases I had. I'll see if I can merge the changes you have made in. Is there any way that you could share a small version of the MRSI data you have (e.g. a single coil version)?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants