Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Switch to new PHPCSStandards/PHP_CodeSniffer package #199

Closed
2 tasks
mindctrl opened this issue Mar 1, 2024 · 1 comment · Fixed by #200
Closed
2 tasks

Switch to new PHPCSStandards/PHP_CodeSniffer package #199

mindctrl opened this issue Mar 1, 2024 · 1 comment · Fixed by #200
Assignees
@mindctrl
Labels
tooling

Comments

@mindctrl
Copy link
Contributor

mindctrl commented Mar 1, 2024

The Squizlabs/PHP_CodeSniffer package has been deprecated. It has been forked and will be maintained under a new package at PHPCSStandards/PHP_CodeSniffer.

Reference: The Future of PHP_CodeSniffer · Issue #3932 · squizlabs/PHP_CodeSniffer

Acceptance Criteria

  • Existing squizlabs package is removed and replaced with the new one.
  • Existing phpcs tests continue to pass. If failures happen after upgrading, the changes needed to make it pass should happen in the same PR.
@justlevine
Copy link
Contributor

@mindctrl this shouldn't be necessary: squizlabs/PHP_CodeSniffer#3932 (comment)

That said, regardless there's no need to include phpcs in this package directly unless you are intentionally pinning a specific version, as it is included upstream from vipcs

@justlevine justlevine mentioned this issue Mar 2, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mindctrl mindctrl

Labels
tooling
Projects
None yet
Milestone
No milestone
2 participants
@mindctrl @justlevine