-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Optimize Backstop Reference Creation in Testing Suites #63
Comments
Scope a solution ✅We can conditionally create backstop reference based on script name by getting the current script during runtime and matching it against an array of scripts we allow reference to be created for. Estimate the effort ✅ |
Hello, Is this the same as #138 ? |
@jeawhanlee @Miraeld any updates on the question above? Is this a duplicate of #138 ? |
It does look like a duplicate with different approach, I'll test this PR to see that it closes this properly. |
Blocked until we have all-green test results. |
Is your feature request related to a problem? Please describe.
Currently, we create backstop references for every test run, regardless of whether they are necessary or not. For instance, even when running tests that do not require backstop references, such as
npm run test:smoke
, we still generate them. This practice consumes unnecessary time during test execution.The issue is here, within hooks.ts
Describe the solution you'd like
As per discussion with @jeawhanlee, we need to optimize backstop reference creation by generating them only for tests that require them. For instance, backstop references will be created when running tests like
npm run test:llcssbg
, which necessitate them for comparison during the test run. Conversely, tests likenpm run test:smoke
, where backstop references are unnecessary, will not trigger their creation, thereby reducing execution time and resource consumption.The text was updated successfully, but these errors were encountered: