-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Domain Replace "With" should always end with slash? #115
Comments
If I understand correctly, S&R plugin should replace strictly "Search for:" to "Replace with:". It is mean Domain Replace "With" should be filled strictly that user want to get, so slash is necessary. This question will be very useful for documentation as example for avoiding problems. |
Right, the function should do what the user add as input. It is in the responsibility of the user. Currently was the old idea to help them. |
Commit related to wp-media#115 adding this question to the documentation as example how to do replace for avoiding problems.
Pull request related to wp-media#115, adding example to the readme.txt as example how to do replace for avoiding problems.
Trying to make a replacement like:
Search For:
http://localhost/wp/search-and-replace/
Replace With:
http://localhost/wp/search-and-replace
I get correctly a new domain url but without slash the url become something like:
http://localhost/wp/search-and-replacewp-content/...
The text was updated successfully, but these errors were encountered: