Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dawn/sdk reorg #70

Draft
wants to merge 8 commits into
base: main
Choose a base branch
from
Draft

Dawn/sdk reorg #70

wants to merge 8 commits into from

Conversation

dawnkelly09
Copy link
Collaborator

Description

Attempt to reorganize and fill out the SDK page a bit. Needed some sort of intro and also added a bit more info found when digging around in the repos.

Checklist

  • [x ] Required - I have added a label to this PR 🏷️
  • [ x] Required - I have run my changes through Grammarly
  • If pages have been moved, I have created redirects in the wormhole-mkdocs repo

@dawnkelly09 dawnkelly09 added the A1 - Maintenance Major Pull request contains major updates to an existing page (i.e., adding a new section, reorgs, etc.) label Sep 11, 2024
Copy link
Collaborator

@eshaben eshaben left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice job cleaning this up!

build/applications/wormhole-sdk.md Outdated Show resolved Hide resolved
@@ -5,148 +5,64 @@ description: Explore Wormhole's TypeScript SDK and learn about how to perform di

# Wormhole TypeScript SDK

The Wormhole TypeScript SDK is useful for interacting with the chains Wormhole supports and the [protocols](#protocols) built on top of Wormhole.
## Get Started
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If this section is about getting started with the SDK, I'd expect to see installation instructions here. Maybe this should be renamed to something else?

I'd also move the first paragraph out to an ## Introduction

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the introduction could benefit from following the recipe for intros outlined in the style guide: https://github.com/papermoonio/documentation-style-guide/blob/main/style-guide.md#introductions

Also in the introduction, make sure you mention what else is covered on this page, i.e., installation, example usage, transfers, etc.

Comment on lines 138 to 156
- `sdk-base` - exposes constants
```sh
npm install @wormhole-foundation/sdk-base
```

- `sdk-definitions` - exposes contract interfaces, basic types, and VAA payload definitions
```sh
npm install @wormhole-foundation/sdk-definitions
```

- `sdk-evm` - exposes EVM-specific utilities
```sh
npm install @wormhole-foundation/sdk-evm
```

- `sdk-evm-tokenbridge` - exposes the EVM Token Bridge protocol client
```sh
npm install @wormhole-foundation/sdk-evm-tokenbridge
```
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know this was previously like this, but maybe it'd look a little bit better in tabs? Not sure 🤔

## Transfers

While using the [`ChainContext`](#chain-context) and [`Protocol`](#protocols) clients directly is possible, the SDK provides some helpful abstractions for doing things like transferring tokens.
While using the `ChainContext` and `Protocol` clients directly is possible, the SDK provides some helpful abstractions for doing things like transferring tokens.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think it hurts to keep the links 🤷‍♀️

@dawnkelly09 dawnkelly09 marked this pull request as draft September 17, 2024 15:15
@eshaben eshaben changed the title Dawn/sdk intro Dawn/sdk reorg Sep 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A1 - Maintenance Major Pull request contains major updates to an existing page (i.e., adding a new section, reorgs, etc.)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants