Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Import specific Wormhole SDK packages #161

Closed
livthomas opened this issue May 21, 2024 · 0 comments · Fixed by #156
Closed

Import specific Wormhole SDK packages #161

livthomas opened this issue May 21, 2024 · 0 comments · Fixed by #156

Comments

@livthomas
Copy link
Contributor

The TypeScript packages in this repository depend on @wormhole-foundation/sdk. But this brings in many unnecessary dependencies as we only need to interact with Solana here.

I quickly went over all the imports and it looks like the dependencies can be reduced to the following subset of Wormhole SDK:

  • @wormhole-foundation/sdk-base
  • @wormhole-foundation/sdk-connect
  • @wormhole-foundation/sdk-definitions
  • @wormhole-foundation/sdk-solana
  • @wormhole-foundation/sdk-solana-core

I would recommend changing all imports from @wormhole-foundation/sdk to these specific packages and remove the dependency on the parent package.
@a5-pickle a5-pickle linked a pull request May 21, 2024 that will close this issue
Create Solver workspace #156
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Create Solver workspace wormhole-foundation/example-liquidity-layer
1 participant
@livthomas