Fix batch creation. #827
Merged
Fix batch creation. #827
+15
−9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cichaczem
approved these changes
Nov 25, 2024
| @@ -39,7 +39,7 @@ pub async fn create_batches( | |||
|
|
|||
| // We start a timer and force it to perform one initial tick to avoid an | |||
| // immediate trigger. | |||
| let mut timer = time::interval(app.config.app.batch_insertion_timeout); | |||
| let mut timer = time::interval(Duration::from_secs(5)); | |||
There was a problem hiding this comment.
Why change from a config value to a constant one?
There was a problem hiding this comment.
We use 5 seconds constant in other tasks and insertion timeout is very big. And when restarted it was waiting batch_insertion timeout before doing a batch while there was enough identities already waiting. :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Solution
PR Checklist