feat: add static appId var (#83)

* Move wallet address to config, add appId to config * add appid on install to demo * move vars to toplevel * missing appid should not break stuff
worldcoin · Oct 24, 2024 · a83c9fb · a83c9fb
1 parent 3316c55
commit a83c9fb
Show file tree

Hide file tree

Showing 3 changed files with 14 additions and 3 deletions.
diff --git a/demo/with-next/components/ClientContent/Versions.tsx b/demo/with-next/components/ClientContent/Versions.tsx
@@ -6,6 +6,8 @@ import {
   MiniKitInstallErrorMessage,
 } from "@worldcoin/minikit-js";
 
+const appId = "your-app-id";
+
 export const Versions = () => {
   const isValid = () => {
     if (
@@ -35,7 +37,7 @@ export const Versions = () => {
   };
 
   const reinstall = () => {
-    MiniKit.install();
+    MiniKit.install(appId);
     JSON.stringify(isValid() ?? null, null, 2);
   };
   return (

diff --git a/demo/with-next/components/MiniKitProvider.tsx b/demo/with-next/components/MiniKitProvider.tsx
@@ -3,9 +3,11 @@
 import { MiniKit } from "@worldcoin/minikit-js";
 import { useEffect, ReactNode } from "react";
 
+const appId = "your-app-id";
+
 export const MiniKitProvider = ({ children }: { children: ReactNode }) => {
   useEffect(() => {
-    MiniKit.install();
+    MiniKit.install(appId);
   }, []);
 
   return <>{children}</>;

diff --git a/packages/core/minikit.ts b/packages/core/minikit.ts
@@ -71,6 +71,7 @@ export class MiniKit {
     [ResponseEvent.MiniAppSignTypedData]: () => {},
   };
 
+  public static appId: string | null = null;
   public static walletAddress: string | null = null;
 
   private static sendInit() {
@@ -140,7 +141,7 @@ export class MiniKit {
     );
   }
 
-  public static install(): MiniKitInstallReturnType {
+  public static install(appId?: string): MiniKitInstallReturnType {
     if (typeof window === "undefined" || Boolean(window.MiniKit)) {
       return {
         success: false,
@@ -150,6 +151,12 @@ export class MiniKit {
       };
     }
 
+    if (!appId) {
+      console.warn("App ID not provided during install");
+    } else {
+      MiniKit.appId = appId;
+    }
+
     if (!window.WorldApp) {
       return {
         success: false,