Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: font size robustness #198

Merged
merged 3 commits into from
Dec 10, 2023
Merged

feat: font size robustness #198

merged 3 commits into from
Dec 10, 2023

Conversation

0xPenryn
Copy link
Contributor

@0xPenryn 0xPenryn commented Dec 6, 2023

uses tailwind config to prevent IDKit styling from being impact by root font-size changes

Copy link

vercel bot commented Dec 6, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
idkit-js-example ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 10, 2023 0:50am

Copy link
Member

@m1guelpf m1guelpf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we should eventually find a better way to do this (maybe switch to iframe vs shadow dom?) but good for now

@0xPenryn 0xPenryn merged commit 44c1a1f into main Dec 10, 2023
3 of 5 checks passed
@0xPenryn 0xPenryn deleted the shopify-font-size-fix branch December 10, 2023 12:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants