Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix!: handle credential_types check when using default #197

Merged
merged 2 commits into from
Dec 7, 2023

Conversation

0xPenryn
Copy link
Contributor

@0xPenryn 0xPenryn commented Dec 6, 2023

  • breaking change refactors createClient in idkit-core to receive input parameters in an object instead of positional arguments.
  • fixes an issue introduced by feat: idkit state and error handling improvements #194 where if credential_types was unset in IDKit parameters, an error would always be thrown upon proof response from bridge
  • makes it explicit how we handle credential_types by default

@0xPenryn 0xPenryn requested a review from pdtfh December 6, 2023 23:19
Copy link

vercel bot commented Dec 6, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
idkit-js-example ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 7, 2023 11:28am

@pdtfh pdtfh changed the title fix: handle credential_types check when using default fix!: handle credential_types check when using default Dec 7, 2023
@igorosip0v igorosip0v self-requested a review December 7, 2023 12:14
@pdtfh pdtfh merged commit 984a190 into main Dec 7, 2023
8 checks passed
@pdtfh pdtfh deleted the fix-credential-type-check branch December 7, 2023 15:17
This was referenced Jan 2, 2024
@github-actions github-actions bot mentioned this pull request Jan 26, 2024
@github-actions github-actions bot mentioned this pull request Mar 30, 2024
Copy link

@gatleas17 gatleas17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@github-actions github-actions bot mentioned this pull request Aug 9, 2024
@github-actions github-actions bot mentioned this pull request Aug 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants