add instrumentation file #1056
Merged
add instrumentation file #1056
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
igorosip0v
temporarily deployed
to
development
GitHub Actions
Inactive
andy-t-wang
temporarily deployed
to
development
GitHub Actions
Inactive
andy-t-wang
approved these changes
Nov 25, 2024
|
Will add to ratings soon, after a slight refactor on calculation |
andy-t-wang
temporarily deployed
to
development
GitHub Actions
Inactive
|
Updated to use Redis globally and for tests |
andy-t-wang
added a commit
that referenced
this pull request
Nov 27, 2024
This reverts commit 5ba5a9e.
andy-t-wang
added a commit
that referenced
this pull request
Nov 27, 2024
andy-t-wang
added a commit
that referenced
this pull request
Nov 27, 2024
andy-t-wang
added a commit
that referenced
this pull request
Nov 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds redis client usage with instrumentation file.
Instrumentation file docs:
https://nextjs.org/docs/app/api-reference/file-conventions/instrumentation
Shortly (but read the doc), we use
register()inside the instrumentation file to execute Redis client creation only once on the application starting after the build. Then, we store the Redis client instance globally to access it everywhere.TODO