Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ErrorInfo from Kingdom public API malformed #1919

Open
SanjayVas opened this issue Nov 14, 2024 · 0 comments
Open

ErrorInfo from Kingdom public API malformed #1919

SanjayVas opened this issue Nov 14, 2024 · 0 comments
Labels
bug Something isn't working

Comments

@SanjayVas
Copy link
Member

SanjayVas commented Nov 14, 2024

The ErrorInfo is missing the domain and code fields. It also appears to include resource IDs in the metadata instead of resource names. For example:

Expected

domain: "halo.wfanet.org"
code: "REQUISITION_STATE_ILLEGAL"
metadata {
  key: "requisition"
  value: "dataProviders/foo/requisitions/AAAAAAAAAHs"
}
metadata {
  key: "state"
  value: "FULFILLED"
}

Actual

metadata {
  key: "requisitionId"
  value: "AAAAAAAAAHs"
}
metadata {
  key: "state"
  value: "FULFILLED"
}

See AIP-193.

@SanjayVas SanjayVas added the bug Something isn't working label Nov 14, 2024
@SanjayVas SanjayVas changed the title ErrorInfo from Kingdom public API contains incorrect code ErrorInfo from Kingdom public API malformed Nov 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant