Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multiple mills claim the same Computation at the same time. #1722

Open
renjiezh opened this issue Jul 31, 2024 · 4 comments
Open

Multiple mills claim the same Computation at the same time. #1722

renjiezh opened this issue Jul 31, 2024 · 4 comments
Assignees
Labels
bug Something isn't working
Milestone

Comments

@renjiezh
Copy link
Contributor

Describe the bug
There are two mill jobs claiming the same Computation. One of the them is a new spawned by the mill scheduler. The other is a continuing mill job.
It caused the later mill job failing the Computation after finishing its stage due to stage mismatch.

Steps to reproduce
Run stress test with multiple data services. There is a chance to reproduce.

Component(s) affected
Duchy

Version
v0.5.7-rc2

Environment
QA env

Additional context
Happened on worker 1 with global ComputationID: DaTIZfrdJI4

@renjiezh renjiezh added the bug Something isn't working label Jul 31, 2024
@renjiezh renjiezh self-assigned this Jul 31, 2024
@renjiezh
Copy link
Contributor Author

It is caused by the spanner implementation of claimTask. The reading(query unclaimed tasks) and writing(claim the task) are not bound in one transaction. Thus there is a chance to lead inconsistency given multiple entities are calling claimTask.

@renjiezh
Copy link
Contributor Author

PR to fix #1726

@SanjayVas
Copy link
Member

Fixed by #1726

@SanjayVas SanjayVas reopened this Aug 7, 2024
@SanjayVas
Copy link
Member

Reopening this as #1726 may have introduced a lock contention issue.

@renjiezh renjiezh changed the title Multiple Computations are claimed at the same time. Multiple mills claim the same Computation at the same time. Aug 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants