Fix bug of enqueuing Computaitons in end stage.

world-federation-of-advertisers · May 19, 2024 · 7c4d5fa · 7c4d5fa
1 parent b5e261c
commit 7c4d5fa
Showing 1 changed file with 5 additions and 0 deletions.
diff --git a/src/main/kotlin/org/wfanet/measurement/duchy/daemon/mill/MillBase.kt b/src/main/kotlin/org/wfanet/measurement/duchy/daemon/mill/MillBase.kt
@@ -164,6 +164,7 @@ abstract class MillBase(
           token,
           "Failing computation due to too many failed ComputationStageAttempts.",
         )
+        return
       }
 
       val wallDurationLogger = wallDurationLogger()
@@ -585,6 +586,10 @@ abstract class MillBase(
 
   /** Enqueue a computation with a delay. */
   private suspend fun enqueueComputation(token: ComputationToken) {
+    require(token.computationStage != endingStage) {
+      "Computation with ending stage cannot be enqueued."
+    }
+
     // Exponential backoff
     val baseDelay = minOf(600.0, (2.0.pow(token.attempt))).toInt()
     // A random delay in the range of [baseDelay, 2*baseDelay]