Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Website doesn't load on Internet Explorer #525

Closed
alexanmtz opened this issue Mar 23, 2020 · 5 comments
Closed

Website doesn't load on Internet Explorer #525

alexanmtz opened this issue Mar 23, 2020 · 5 comments
Assignees
Labels
bug Fullstack hiring Issues that can help you to solve hiring challenges react Task that require react knowledge starter issue for starter developers

Comments

@alexanmtz
Copy link
Member

On our Find a bug and fix program #272, one of our members reported that the site is not opening on Internet Explorer.

Level

Beginner

@alexanmtz alexanmtz added bug react Task that require react knowledge starter issue for starter developers Fullstack hiring Issues that can help you to solve hiring challenges labels Mar 23, 2020
@alexanmtz alexanmtz added this to the v1.7-apollo milestone Mar 23, 2020
@Shawn-Noruzi
Copy link
Contributor

Hey @alexanmtz

I'll work on this, please assign it to me.

@alexanmtz
Copy link
Member Author

Yes @Shawn-Noruzi , you're now assigned 👍

@Shawn-Noruzi
Copy link
Contributor

Shawn-Noruzi commented Aug 13, 2020

Some progress - still has bugs however.
Things I've tried :

1.Having babel build with Ie>=11 in mind through modifying the .babelrc file

2.@babel/preset-env added with babel-core packages
edited .babelrc to include "defaults" range of support for browsers

Ran into build issue stating conflict with babel-core and @babel-core versions
Removed babel-core and replaced with @babel-core v 7.0.0 to resolve build issue
Issue remains

babel -V shows we are working with version 6.26 babel -> Looking through 6.26 docs for Babel to find support for IE.
babel-cli and babel-preset-env are for version 6.x and will not work with babel 7 packages (@babel/xxx)

3.Added proper support for IE11 with Babel 6.26 into .babelc

4.Got a regeneratorRuntime error:
npm install --save-dev babel-plugin-transform-runtime babel-runtime + added babelrc lines for plugin support for runtime

Ran into Styled-components + promise undefined errors

  1. Installed Babel-polyfill to remove promise undefined error
    npm install --save babel-polyfill
    import "babel-polyfill"; in index.js at the very TOP before even importing react

Site now displays but overall UI interaction is slow with some features not even working properly such as the navbar scroll-to-element

Will continue to investigate

@alexanmtz
Copy link
Member Author

Thanks @Shawn-Noruzi, so now we have a better view of the complexity to support this

@alexanmtz alexanmtz removed this from the v1.7-apollo milestone Dec 15, 2020
@alexanmtz
Copy link
Member Author

It works on Edge

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Fullstack hiring Issues that can help you to solve hiring challenges react Task that require react knowledge starter issue for starter developers
Projects
Status: Done
Development

No branches or pull requests

2 participants