FIXES: fix lint issues Fixes: #1106
Conversation
|
Hey @Anshgrover23 , thanks for the PR and great progress on this one, but you still need to set up the right ECMA script version to avoid errors on conditional chaining ( There are still indentation errors to fix and unused variables to get all issues resolved, so please check those. And we need to figure out why the tests are failing. |
There was a problem hiding this comment.
@Anshgrover23 please check these unneeded dependencies added
There was a problem hiding this comment.
We have still these issues to address, but in general if you use it the lint-fix option, I would like to change to no semicolons in the end of the statement.
and some inconsistencies on the solution, sometimes you remove unused variables and others you comment to ignore the next line, other example you just remove, so it's better to have one solution, like remove those
| return done(err) | ||
| }; | ||
| // console.log('err', err) | ||
| // return done(err) |
There was a problem hiding this comment.
you're commenting here a line that can affect the tests besides the console, please don't do so.
You can remove the console and keep the line with the return
| orderMail.expiredOrders(order) | ||
| return; |
There was a problem hiding this comment.
you removed a return statement needed here
| @@ -112,7 +112,7 @@ const fetchTransferSuccess = (data) => { | |||
|
|
|||
| const fetchTransferFailed = (error) => { | |||
| return { | |||
| type: FETCH_TRANSFER, | |||
| type: FETCH_TRANSFER_FAILED, | |||
| this.setState({ error: { ...this.state.error, fullname: true } }); | ||
| } else { | ||
| this.setState({ error: { ...this.state.error, fullname: false } }); | ||
| } | ||
| } | ||
|
|
||
| onChangeEmail (ev) { | ||
| onChangeEmail(ev) { | ||
| if (ev.target.value.length < 1) { | ||
| this.setState({ error: { email: true } }) | ||
| } | ||
| else { | ||
| this.setState({ error: { email: false } }) | ||
| this.setState({ error: { ...this.state.error, email: true } }); | ||
| } else { | ||
| this.setState({ error: { ...this.state.error, email: false } }); |
There was a problem hiding this comment.
I think we need to keep the current state here because it's a object with nested keys
| if(user) {1+1} | ||
| if(hideExtra) {1+1} | ||
| if(size) {1+1} | ||
| if(classes) {1+1} |
| componentWillMount () { | ||
| const token = this.props.match.params.token | ||
| const referer = Auth.getReferer() | ||
| componentDidMount() { |
|
Hey @Anshgrover23 , we just merged the #1107 So we will work from there and I will create a new issue to remove the warnings so I will close this one. |
|
Ok alex .
…On Fri, 21 Jun, 2024, 3:14 pm Alexandre Magno, ***@***.***> wrote:
Hey @Anshgrover23 <https://github.com/Anshgrover23> , we just merged the
#1107 <#1107>
So we will work from there and I will create a new issue to remove the
warnings so I will close this one.
—
Reply to this email directly, view it on GitHub
<#1106 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/BIHKKQ7CCGYDFWPHJZDBTJDZIPYW7AVCNFSM6AAAAABJIQHPGGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCOBSGQYDGNBQG4>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
fixes: #1038
Description
=> There were over 129 lint issues which i have fixes of type indentation errors,
FIXES: fix lint issues Fixes:
/claim #1038
Screenshots