solving issue #1082 #1084
Closed
solving issue #1082 #1084
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexanmtz
reviewed
Apr 5, 2024
There was a problem hiding this comment.
Thanks for your contribution @borthdor
I found out that this should be fixed on the back-end to not have any manipulation on the reducer side and make sure the updated data is returned, and we have our sync with status from Github needs to revisited.
Comment on lines
+105
to
+107
| // Find the index of the task to be updated | ||
| const taskIndex = state.data.findIndex(t => t.id === updatedTaskData.id); | ||
| // Create a new array for tasks with the updated task data |
There was a problem hiding this comment.
I think you're trying to find a task in a list of tasks, but this is a single task reducer, so it should have from the back-end the task updated, and I fixed for now on the back-end.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
Updated the code to fix the named error. Please review