Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow user sort #1075

Merged
merged 4 commits into from
Feb 24, 2024
Merged

Allow user sort #1075

merged 4 commits into from
Feb 24, 2024

Conversation

Precious-Macaulay
Copy link
Contributor

@Precious-Macaulay Precious-Macaulay commented Feb 22, 2024

See #1013

@Precious-Macaulay
Copy link
Contributor Author

Precious-Macaulay commented Feb 22, 2024

@alexanmtz I have updated the code #1013

@alexanmtz
Copy link
Member

@Precious-Macaulay still not seeing any record on the table when we filter on other tabs:
pageshot of 'Gitpay - Bounties for git issues solved' @ 2024-02-23-1306'08

And when I tested on the value table along with issues with no bounties, the sorting fails, try to cover this case too.

Can you please check these issues?

@Precious-Macaulay
Copy link
Contributor Author

Alright i will work on that now

@Precious-Macaulay
Copy link
Contributor Author

Also @alexanmtz is there away i can populate my local database to test everything before pushing since migration and seeding only creates 3 task and nothing on the other filters tabs

@alexanmtz
Copy link
Member

Also @alexanmtz is there away i can populate my local database to test everything before pushing since migration and seeding only creates 3 task and nothing on the other filters tabs

@Precious-Macaulay you can edit the seed to have more tasks, or manually add tasks yourself. You can use my test repository do import issues: https://github.com/alexanmtz/test-repository

We have our front-end tests that you can use to unit test the component, but I guess it would take longer and not required now.

@Precious-Macaulay
Copy link
Contributor Author

Precious-Macaulay commented Feb 24, 2024

@Precious-Macaulay still not seeing any record on the table when we filter on other tabs: pageshot of 'Gitpay - Bounties for git issues solved' @ 2024-02-23-1306'08

And when I tested on the value table along with issues with no bounties, the sorting fails, try to cover this case too.

Can you please check these issues?

@alexanmtz I have checked all issue

  1. not seeing any record on the table -- it is because there is no record, when i imported an issue i could the record got updated and i could see the issues
    the actual problem was that the conditional component to render when "no issues " was not returned of which i have fixed.
  2. for this And when I tested on the value table along with issues with no bounties, the sorting fails, try to cover this case too. --- no bounties means the values is 0 so they all maintain their position when sorted since they all have same value.

Additional update is that i handled the null, date and label sorting better to ensure better precision in sorting.

Screenshot (24)

Screenshot (25)

@alexanmtz
Copy link
Member

Great @Precious-Macaulay, now it's working great 💯

Let's merge it and thanks for all your effort to get the final result 🥇

@alexanmtz alexanmtz merged commit 4e1b763 into worknenjoy:master Feb 24, 2024
1 check failed
@Precious-Macaulay
Copy link
Contributor Author

You're welcome!
I look forward to more contribution.😊

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants