Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Friendly Display of Date in Intransit Delivery Message Mail #549 #1037

Merged
merged 4 commits into from
Jan 10, 2024

Conversation

KenjxJJ
Copy link
Contributor

@KenjxJJ KenjxJJ commented Jan 10, 2024

Description

Add friendly dates in the mail

Changes

  • Date format in the mail formatted in friendly display

Issue

Closes #549

Impacted Area

Main page

Steps to test

Steps needed to reproduce the scenario from this change to validate if the pull request solve this issue

  • Create / log user
  • Create Task
  • Other steps

Before

Screenshot from the state before

After

Screenshot from the state after your Pull Request

Copy link
Member

@alexanmtz alexanmtz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @KenjxJJ , it sounds great that you found the solution.

But we can see in the PR there's many changes on libraries and package, please push just the changes regarding the task.

To get your packages version to master you need to run the following commands, then, push:

git checkout master -- frontend/package-lock.json
git checkout master -- frontend/package.json
git checkout master -- package-lock.json

So you can get the versions from master and just send your change

Then we will see afterwards why it only works for you using these versions

@KenjxJJ
Copy link
Contributor Author

KenjxJJ commented Jan 10, 2024

Done as requested.

Copy link
Member

@alexanmtz alexanmtz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great @KenjxJJ 🎉 🎉 🎉 🎉

@alexanmtz alexanmtz merged commit 2b6d04f into worknenjoy:master Jan 10, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Display friendly dates on mail notifications
2 participants