Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: remove -fvisibility=hidden #590

Merged
merged 1 commit into from
Sep 11, 2023
Merged

fix: remove -fvisibility=hidden #590

merged 1 commit into from
Sep 11, 2023

Conversation

andyholmes
Copy link
Contributor

This is an internal library anyways and seemed to be causing some problems, or at least warnings, when compiling other parts of Workbench.

@andyholmes
fix: remove -fvisibility=hidden
69d2956 
This is an internal library anyways and seemed to be causing some
problems, or at least warnings, when compiling other parts of Workbench.
@andyholmes andyholmes requested a review from sonnyp as a code owner September 10, 2023 18:38
@andyholmes
Copy link
Contributor Author

Possibly addresses #588

sonnyp
sonnyp approved these changes Sep 11, 2023
View reviewed changes
Copy link
Contributor

@sonnyp sonnyp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It won't fix #588 but it does solve the compilation errors during build.

Thanks

@sonnyp sonnyp merged commit 0dcadc5 into main Sep 11, 2023
1 check passed
@sonnyp sonnyp deleted the andyholmes/libworkbench-visibility branch September 11, 2023 12:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sonnyp sonnyp sonnyp approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@andyholmes @sonnyp