Ported Overlay Split View in Rust
#559
Conversation
There was a problem hiding this comment.
Reading this chapter should clear some things up.
https://gtk-rs.org/gtk4-rs/stable/latest/book/g_object_memory_management.html
| let overlay_split_view: Rc<RefCell<adw::OverlaySplitView>> = Rc::new(RefCell::new( | ||
| workbench::builder().object("split_view").unwrap(), | ||
| )); |
There was a problem hiding this comment.
You should need neither Rc nor RefCell here.
GObjects already behave like Rc<RefCell<T>>
| let overlay_split_view_clone = overlay_split_view.clone(); | ||
| start_toggle.connect_toggled(move |_| { |
There was a problem hiding this comment.
You can use glib::clone! here.
| let overlay_split_view_clone = overlay_split_view.clone(); | ||
| end_toggle.connect_toggled(move |_| { |
There was a problem hiding this comment.
Also use glib::clone! here
There was a problem hiding this comment.
Also use
glib::clone!here
Made the changes please check again, and thanks again for the memory management resource it helped a lot. :)
There was a problem hiding this comment.
I've changed your code slightly.
You can find the changes here: 6ad7246
There was a problem hiding this comment.
I've added some comments as well. @Hofer-Julian Can you confirm if there's any difference with and without the changes that I suggested..?
| .set_sidebar_position(gtk::PackType::Start); | ||
| })); | ||
|
|
||
| end_toggle.connect_toggled(glib::clone!(@strong overlay_split_view =>move |_| { |
There was a problem hiding this comment.
clone! is not needed here.
| let start_toggle: gtk::ToggleButton = workbench::builder().object("start_toggle").unwrap(); | ||
| let end_toggle: gtk::ToggleButton = workbench::builder().object("end_toggle").unwrap(); | ||
|
|
||
| start_toggle.connect_toggled(glib::clone!(@strong overlay_split_view => move |_| { |
There was a problem hiding this comment.
Use @weak reference to the overlay_split_view here.
|
I agree with @saadulkh suggestions |
Added them , thanks to both of you for your suggestions :) |
Hey. I ported
Overlay Split Viewin Rust.Tried to follow the Java Script code, but there were ownership errors so i had to use
ref celllibrary andborrow_mut()function to resolve the ownership issues forsplit view.Please check this approach it works correctly on my machine and let me know on how can i make it better.