Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

library: Ported NavigationView to rust #558

Merged
merged 1 commit into from
Aug 29, 2023
Merged

library: Ported NavigationView to rust #558

merged 1 commit into from
Aug 29, 2023

Conversation

saadulkh
Copy link
Contributor

Adds rust version of the NavigationView library.

Noticeable differences:

  • switch of JavaScript is replaced with if-else statements.
  • current_page variable is used at two places to avoid multiple function calls.

Lemme know if the current_page is unnecessary for the use case.

@saadulkh saadulkh requested a review from Hofer-Julian as a code owner August 29, 2023 18:32
Hofer-Julian
Hofer-Julian reviewed Aug 29, 2023
View reviewed changes
Copy link
Contributor

@Hofer-Julian Hofer-Julian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apart from the comment, it looks good :)

src/Library/demos/Navigation View/code.rs Show resolved Hide resolved
@saadulkh saadulkh requested a review from Hofer-Julian August 29, 2023 19:19
Hofer-Julian
Hofer-Julian approved these changes Aug 29, 2023
View reviewed changes
Copy link
Contributor

@Hofer-Julian Hofer-Julian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@Hofer-Julian Hofer-Julian merged commit 2514cbe into workbenchdev:main Aug 29, 2023
1 check passed
@saadulkh saadulkh deleted the rust-navview branch August 30, 2023 01:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Hofer-Julian Hofer-Julian Hofer-Julian approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@saadulkh @Hofer-Julian