Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BE] 인원 변동 기능 구현 #47
[BE] 인원 변동 기능 구현 #47
Changes from 7 commits
c991e8e
ff15069
e62e2f7
ad15f5b
14b730c
a6c7b70
db16486
9cec9fe
008f501
ade90fc
04a40e2
60b2b34
1c1a2bd
c7de8bd
e81bbad
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
c: DTO에 일급컬렉션을 적용하면 어떤 이점이 있을까요?
presentation 단에서는 주고받는 json형태를 객체로 하기 위해 일급컬렉션을 사용했는데요. application단의 dto까지 일급컬렉션을 적용해야하는지 잘 모르겠습니다. 감싸고 푸는 번거로움만 늘어가는 것 같아요.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
지금의 DTO 구조에서 얻을 수 있는 이점이라고 하면 JSON 요청 본문에 포함되는 데이터가 현재 List 이외에 추가된다면 MemberActionsSaveRequest 객체의 속성으로 쉽게 넣을 수 있다는 점이 있습니다. 저희가 논의했을 때는 요청 본문을 List로 받게되면 요청 데이터가 추가되거나 변경될 때 확장성이 떨어진다고 생각하여 한 번 더 감싸서 받기로 결정했었던 것 같아요. 저도 팀원들과 함께 다시 논의해볼 필요는 있다고 생각합니다.